TST: prepare conftest for #25637#26596
Conversation
Codecov Report
@@ Coverage Diff @@
## master #26596 +/- ##
===========================================
- Coverage 91.84% 41.69% -50.16%
===========================================
Files 174 174
Lines 50644 50644
===========================================
- Hits 46516 21116 -25400
- Misses 4128 29528 +25400
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #26596 +/- ##
==========================================
- Coverage 91.84% 91.84% -0.01%
==========================================
Files 174 174
Lines 50644 50644
==========================================
- Hits 46516 46512 -4
- Misses 4128 4132 +4
Continue to review full report at Codecov.
|
simonjayhawkins
added
Testing
|
@gfyoung |
| FixedOffset(0), FixedOffset(-300), timezone.utc, | ||
| timezone(timedelta(hours=1)), | ||
| timezone(timedelta(hours=-1), name='foo')] | ||
| TIMEZONE_IDS = ['None', 'UTC', 'US/Eastern', 'Asia/Tokyp', |
There was a problem hiding this comment.
pls don’t merge things until i look
this is duplicating too much code here
There was a problem hiding this comment.
what is the point of of these extras?
There was a problem hiding this comment.
maybe so but that other has not been reviewed at all
There was a problem hiding this comment.
this is not done in a nice way
these should simply be tuples of timezone and id and unpacked when needed
can u do a PR to fix
There was a problem hiding this comment.
and to be honest these may not even be needed to do it like this it’s a lot more verbose
There was a problem hiding this comment.
The unpacking option seems to overcomplicate as you mentioned. Alternatively, we can just do a list comprehension and pull the __repr__ (or __str__) on the elements of TIMEZONES. That would still keep the IDs but be less "duplicative".
There was a problem hiding this comment.
yes i think a nice function would be fine
There was a problem hiding this comment.
@jreback: this is not done in a nice way
I disagree. Compare the outputs of @gfyoung's PR with the state I introduced.
I made the IDs explicit precisely because the strs/reprs yields a useless, ugly mix of stuff. Saving these 4 lines is not worth the added hassle when actually debugging tz-tests with pytest -v.
Follow-up to pandas-devgh-26596
Follow-up to pandas-devgh-26596
Follow-up to pandas-devgh-26596
Follow-up to pandas-devgh-26596
Follow-up to pandas-devgh-26596
Follow-up to pandas-devgh-26596
Follow-up to pandas-devgh-26596
4 participants
Split off from #25637 at the request of @gfyoung
Relevant discussions:
#25637 (comment)
#25637 (comment)